go.mod: fix dependencies #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
Member
Contributor
Author
|
The issue is that |
Fix build issue:
go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/rest/request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
Follow
https://github.com/kubernetes/client-go/blob/master/INSTALL.md#go-modules
and use the latest release of kubernetes instead. Fixed with:
make tools
Contributor
Author
zimbatm
commented
Dec 10, 2019
| k8s.io/api v0.0.0-20191121015604-11707872ac1c | ||
| k8s.io/apiextensions-apiserver v0.0.0-20191121021419-88daf26ec3b8 | ||
| k8s.io/apimachinery v0.0.0-20191121015412-41065c7a8c2a | ||
| k8s.io/client-go v11.0.0+incompatible |
Contributor
Author
There was a problem hiding this comment.
this is the important line in the changeset
Member
|
👍 |
1 similar comment
Member
|
👍 |
Member
|
Thanks @zimbatm for providing this fix. For some reason, I didn't ran into these issues. But, go-client version should not be raised by the kind client. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
go test -v ./...on master currently fails with:Follow
https://github.com/kubernetes/client-go/blob/master/INSTALL.md#go-modules
and use the latest release of kubernetes instead. Fixed with:
There are also failing tests that are not fixed by this PR.