-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling #144
Conversation
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Instead of just aborting on the first encountered error, try to proceed and reconcile the remaining resources. The only thing that currently causes a hard error is UpdateFromResources(), the rest should be logged, reported as an event and ignored. StackContainer logic has been adjusted to check other stack resources in IsReady() as well to prevent a situation where traffic is directed to a stack that can't be reconciled. Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Pull Request Test Coverage Report for Build 997
💛 - Coveralls |
This apparently doesn't work at all for HPA resources for some reason. Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Could you say why |
It's clear why the |
@muaazsaleem We can't really proceed if |
I think my question is too generic, I'll follow up with more specific ones if I have them |
👍 |
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
👍 |
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
👍 |
2 similar comments
👍 |
👍 |
Instead of just aborting on the first encountered error, try to proceed and reconcile the remaining resources. The only thing that currently causes a hard error is
UpdateFromResources()
, the rest should be logged, reported as an event and ignored.StackContainer
logic has been adjusted to check other stack resources inIsReady()
as well to prevent a situation where traffic is directed to a stack that can't be reconciled.