add show_time_lag to subscription stats function

[roisin-jin]

This PR is to add the flag show_time_lag to the subscription stats endpoint to be aligned with the nakadi doc, so the subsequent response will populate the consumer time lag field (if nakadi computation not times-out)

Reference: https://nakadi.io/manual.html#/subscriptions/subscription_id/stats_get

[gchudnov]

overall looks good, but need to check why tests are failing...
since we cannot merge without them.

[roisin-jin]

overall looks good, but need to check why tests are failing... since we cannot merge without them.

Ya I'm not sure why those tests are failing, the change we put in here doesnt seem to effect tests at all?

[roisin-jin]

Hi @gchudnov I've updated the PR here if you can give the integration test another run? Thanks

[gchudnov]

hm. it looks there is a problem with docker image for nakadi that are being used for testing. The Nakadi Server seems to be not working (?).

Need to reproduce manually and contact the creator of the image if there is a problem

[roisin-jin]

hm. it looks there is a problem with docker image for nakadi that are being used for testing. The Nakadi Server seems to be not working (?).

Need to reproduce manually and contact the creator of the image if there is a problem

it looks like there's known issue with linux of the latest version since it's released this March, I've changed the version back to previous one to see if it works? @gchudnov

[gchudnov]

hm.. failing..

[coveralls]

Pull Request Test Coverage Report for Build 3014322905

• 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
• 12 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+0.3%) to 74.953%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/main/scala/org/zalando/kanadi/api/Subscriptions.scala	2	3	66.67%

Files with Coverage Reduction	New Missed Lines	%
src/main/scala/org/zalando/kanadi/api/EventTypes.scala	1	93.81%
src/main/scala/org/zalando/kanadi/models/PaginationLink.scala	1	50.0%
src/main/scala/org/zalando/kanadi/models/ReadScope.scala	1	50.0%
src/main/scala/org/zalando/kanadi/models/StreamId.scala	1	50.0%
src/main/scala/org/zalando/kanadi/models/SubscriptionId.scala	1	50.0%
src/main/scala/org/zalando/kanadi/models/PartitionCompactionKey.scala	2	0%
src/main/scala/org/zalando/kanadi/api/Subscriptions.scala	5	70.09%

Totals
Change from base Build 1638988635:	0.3%
Covered Lines:	395
Relevant Lines:	527

---

💛 - Coveralls