Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Trial run is adding a new record in the browser's history everytime a character typed in one of the view's text areas #572

Open
elauria opened this issue May 2, 2018 · 3 comments
Open

Trial run is adding a new record in the browser's history everytime a character typed in one of the view's text areas #572

elauria opened this issue May 2, 2018 · 3 comments
Assignees
@elauria
Labels
bug user-reported issues that take more than one hour to resolve

Comments

@elauria
Copy link
Contributor

elauria commented May 2, 2018

By using location.replace() all changes on location would not be added as one entry in the history, which helps to not pollute the history with unneeded entries.
@elauria elauria self-assigned this May 2, 2018
elauria pushed a commit that referenced this issue May 2, 2018
#572 add location.replace
f74154a
This was referenced May 2, 2018
Merged
Closed
elauria pushed a commit that referenced this issue May 2, 2018
#572 fix delivery
98d046f
elauria pushed a commit that referenced this issue May 2, 2018
Merge pull request #573 from zalando-zmon/572-location_replace
5aac1d3 
#572 add location.replace
@elauria elauria closed this as completed May 23, 2018
@aermakov-zalando
Copy link

This seems to be broken again:

image

@alexkorotkikh
Copy link
Contributor

@lfroment0 could you please take a look?

@lfroment0
Copy link
Contributor

In order to have only one history record for trial run, we have to enable the $locationProvider's html5mode.

From what I've understood there needs to be some changes made in the controller to redirect the user to index.html on every front-end navigation, so that angular can handle the redirection by itself, and thus the browser's history.

I'm currently working on it here: #687

@lfroment0 lfroment0 reopened this Apr 30, 2019
@lfroment0 lfroment0 changed the title use location.replace() to improve history Trial run is adding a new record in the browser's history everytime a character typed in one of the view's text areas Apr 30, 2019
@pitr pitr added the bug user-reported issues that take more than one hour to resolve label May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elauria elauria

Labels
bug user-reported issues that take more than one hour to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pitr @alexkorotkikh @elauria @lfroment0 @aermakov-zalando