Stop warning about NaNs #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en using derived KPIs
shansfolder
approved these changes
Aug 16, 2018
|
@aaron-mcdaid-zalando could you pls elaborate on that? What happens if all of the data points are NaNs? Do we accept NaNs as valid values for means/std/p-values? |
|
Currently, for means/std/p-values/sample-sizes, the NaNs are discarded. So the NaN values aren't really an issue (except that So, we should forget about the NaNs, and instead count the number of non-NaNs. Longer term, a lot of this needs to be redone entirely though :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop warning about NaNs. They are perfectly legitimate datapoints, when using derived KPIs
Longer term, perhaps there is an appropriate place to print the numbers of NaNs in the input data, in a nicely-tabulated piece of text. But the current warning is very spammy