Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Add link to an application template #62

Merged
merged 1 commit into from
May 3, 2017
Merged

Conversation

jcranky
Copy link
Contributor

@jcranky jcranky commented May 2, 2017

Said template will generate a fully setup grafter application
with http4s.

Said template will generate a fully setup grafter application
with http4s.
@jcranky
Copy link
Contributor Author

jcranky commented May 2, 2017

👍

1 similar comment
@etorreborre
Copy link
Contributor

👍

@etorreborre
Copy link
Contributor

Pretty cool!

@etorreborre
Copy link
Contributor

A few comments on the template. I would:

  • rather use annotations instead of genericReader
  • rather use .start instead of Rewriter.start
  • use singletons to show the configuration of application components
  • replace httpServer by httpServerConfig to avoid confusion

@etorreborre etorreborre deleted the grafter-http4s-template branch May 3, 2017 07:38
@jcranky
Copy link
Contributor Author

jcranky commented May 3, 2017

@etorreborre thanks for feedback on the template, I'll address them :)

@jcranky
Copy link
Contributor Author

jcranky commented May 6, 2017

@etorreborre I did the change to use annotations: jcranky/grafter-http4s.g8@bcb200d - interesting fact: the compilation times for the generated project with the annotations is about 50% faster then the previous version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants