create support for absent header condition #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikhail-Polivakha
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
| @@ -78,4 +78,8 @@ private Conditions() { | |||
| e.getValue().stream().anyMatch(v -> predicate.test(e.getKey(), v))); | |||
| } | |||
|
|
|||
| public static <T extends HttpMessage> Predicate<T> withoutHeader(String headerName) { | |||
There was a problem hiding this comment.
Suggested change
| public static <T extends HttpMessage> Predicate<T> withoutHeader(String headerName) { | |
| public static <T extends HttpMessage> Predicate<T> withoutHeader(final String headerName) { |
|
👍 |
|
Thank you for your contribution! 📣 I released your change as 2.8.0 to central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create additional condition in order to support condition - "header is absent in http request"
Motivation and Context
Encounter in our project. Requirement was to disable logging for requests (and corresponding responses) without certain headers
Types of changes
New feature (and corresponding tests for it also goes along)
Checklist:
Required tests have been already created. Consider to doc this change somewhere. If you will provide me with the link I can supply with one :)