Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Apache Maven Wrapper #1504

Merged
merged 1 commit into from
May 30, 2023
Merged

Use Apache Maven Wrapper #1504

merged 1 commit into from
May 30, 2023

Conversation

msdousti
Copy link
Collaborator

@msdousti msdousti commented May 25, 2023 •
edited

Inspired by #1502, plus adds updated maven files.
(The maven files were borrowed from the latest skeleton project created by Spring Initializr).

Description

Use official Apache Maven Wrapper

https://maven.apache.org/wrapper/

Motivation and Context

Replace Takari Wrapper with the official Apache wrapper

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@msdousti msdousti changed the title use Apache Maven Wrapper Use Apache Maven Wrapper May 25, 2023
@msdousti msdousti mentioned this pull request May 25, 2023
Closed
6 tasks
@kasmarian
Copy link
Member

👍

@msdousti msdousti merged commit 51f703c into main May 30, 2023
2 checks passed
@kasmarian kasmarian deleted the apache-maven-wrapper branch June 7, 2023 08:47
kasmarian pushed a commit that referenced this pull request Jun 7, 2023
@msdousti @kasmarian
use Apache Maven Wrapper (#1504)
4aec3a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msdousti @kasmarian