Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Apache Maven Wrapper #1502

Closed
wants to merge 1 commit into from
Closed

use Apache Maven Wrapper #1502

wants to merge 1 commit into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented May 20, 2023

Description

use official Apache Maven Wrapper

https://maven.apache.org/wrapper/

Motivation and Context

replace Takari Wrapper with the official Apache wrapper

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@msdousti msdousti mentioned this pull request May 25, 2023
Merged
6 tasks
@msdousti
Copy link
Collaborator

Thanks a lot for the suggestion.
I used a new maven-warpper.properties file, along with updated mvnw and mvnw.cmd in a new PR: #1504.

@msdousti msdousti closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sullis @msdousti