Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added correlation id to curl log #170

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Added correlation id to curl log #170

merged 1 commit into from
Jul 3, 2017

Conversation

whiskeysierra
Copy link
Collaborator

Fixes #160

@AlexanderYastrebov
Copy link
Member

👍

@AlexanderYastrebov
Copy link
Member

👍

@whiskeysierra whiskeysierra merged commit 1c53eb6 into master Jul 3, 2017
AlexanderYastrebov
AlexanderYastrebov reviewed Jul 3, 2017
View reviewed changes
logbook-spring-boot-starter/src/test/java/org/zalando/logbook/spring/FormatStyleCurlTest.java
@@ -55,7 +55,7 @@ public void shouldUseHttpFormatter() throws IOException {

private Matcher<Precorrelation<String>> isCurlFormatter() {
final Function<Precorrelation<String>, String> getRequest = Precorrelation::getRequest;
return hasFeature("request", getRequest, is("curl -v -X GET 'http://localhost/'"));
return hasFeature("request", getRequest, containsString("curl -v -X GET 'http://localhost/'"));
}

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line?

@whiskeysierra whiskeysierra deleted the feature/curl-correlation-id branch July 3, 2017 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov AlexanderYastrebov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whiskeysierra @AlexanderYastrebov