deprecate crd validation toggle and sync with manifests #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
2 similar comments
|
👍 |
|
👍 |
|
I think this should be a new release, because I'm still affected by v1.7.1 and it keeps failing to validate some crds. |
|
Getting this error as well on latest release, would be nice to get an 1.7.2 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1497
Fixes #1731
Fixes #1737
Closes #1738
We had some inconsistencies between the CRD manifests and the internal CRD representation that the operator tries to register/update (thanks @bchrobot for the diff list).
This PR deprecates the EnableCRDValidation toggle, since a structural schema is required in v1. This will also fix registering the OperatorConfiguration CRD by the operator.
Last but not least, the PR introduces a new options to configure the categories in which the CRDs are registered - addressing the feature request in #1779.
allremains the default. ToDo: Allow configuring categories in helm chart. At the moment, CRDs are not templates.