Skip to content

Commit

Permalink
fix: concurrently fetch metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
AnshulMalik committed Apr 7, 2024
1 parent 8228f28 commit c3b244c
Showing 1 changed file with 30 additions and 9 deletions.
39 changes: 30 additions & 9 deletions internal/insight/insight.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ package insight

import (
"context"
"sync"
"time"

"github.com/aws/aws-sdk-go-v2/aws"
Expand Down Expand Up @@ -65,17 +66,37 @@ func (in *Insight) Fetch(ctx context.Context, dbiResourceId string, dur time.Dur
chunks = append(chunks, metrics[i:end])
}

// TODO: concurrent
childContext, cancel := context.WithCancel(ctx)
defer cancel()

samples := map[string]Samples{}
for _, chunk := range chunks {
set, err := in.fetch(ctx, dbiResourceId, dur, chunk...)
if err != nil {
return nil, err
}
var wg sync.WaitGroup
var err error

for k, v := range set {
samples[k] = v
}
for _, chunk := range chunks {
chunk := chunk
wg.Add(1)

go func() {
defer wg.Done()

set, e := in.fetch(childContext, dbiResourceId, dur, chunk...)
if e != nil {
if e != context.Canceled {
cancel()
err = e
}
return
}

for k, v := range set {
samples[k] = v
}
}()
}
wg.Wait()
if err != nil {
return nil, err
}

return samples, nil
Expand Down

0 comments on commit c3b244c

Please sign in to comment.