Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API usage monitoring filter improvements #949

Closed
maxim-tschumak opened this issue Feb 11, 2019 · 0 comments
Closed

API usage monitoring filter improvements #949

maxim-tschumak opened this issue Feb 11, 2019 · 0 comments

Comments

@maxim-tschumak
Copy link
Contributor

Acceptance criteria

  • Use {no-match} placeholder for non-matching paths and clients
  • Use curly brackets to identify path parameters and placeholders
  • Configure realms globally (which realms have to be monitored)
  • Configure client patterns on the filter config level
  • Filter creation should fail if not all mandatory parameters are supplied

In order to not break the compatibility to previous global configurations, the api-usage-monitoring-default-client-tracking-pattern global parameter is still allowed but will be ignored. It will be completely removed in the near future.
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): use {no-match} for not matched pat…
b3aa701 
…hs (instead of <unknown>) (zalando#949)
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): fail (not create a filter) on inva…
9fbb715 
…lid config (zalando#949)
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): path parameters in curly braces (z…
3aaf3a1 
…alando#949)
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): realms via global config and clien…
ff95655 
…t pattern on filter level (incompatible interface change) (zalando#949)
@maxim-tschumak maxim-tschumak mentioned this issue Feb 11, 2019
Merged
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): use {no-match} for not matched pat…
6de5ee6 
…hs (instead of <unknown>) (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): fail (not create a filter) on inva…
b4d6fc3 
…lid config (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): path parameters in curly braces (z…
b3f968c 
…alando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak pushed a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): realms via global config and clien…
12d8135 
…t pattern on filter level (incompatible interface change) (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): use {no-match} for not matched pat…
4f0e734 
…hs (instead of <unknown>) (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): fail (not create a filter) on inva…
4f8e6dc 
…lid config (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): path parameters in curly braces (z…
0ec4fd3 
…alando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): realms via global config and clien…
a5442b7 
…t pattern on filter level (incompatible interface change) (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 11, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): realms via global config and clien…
eb5ea86 
…t pattern on filter level (incompatible interface change) (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 12, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): improvements proposed by @tkrop (z…
782a55d 
…alando#949)
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 12, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): improvements proposed by @tkrop (z…
cc7cc67 
…alando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 12, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): improvements proposed by @tkrop (z…
f5517f6 
…alando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 12, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): improvements proposed by @tkrop (z…
df0657e 
…alando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 13, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): use regex for realms to track (zal…
0eb18b9 
…ando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 13, 2019
@maxim-tschumak
feat(api-usage-monitoring-filter): use regex for realms to track (zal…
d3c7c48 
…ando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
aryszka pushed a commit that referenced this issue Feb 13, 2019
@maxim-tschumak @aryszka
API usage monitoring filter improvements (#950)
adbe416 
* feat(api-usage-monitoring-filter): use {no-match} for not matched paths (instead of <unknown>) (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* feat(api-usage-monitoring-filter): fail (not create a filter) on invalid config (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* feat(api-usage-monitoring-filter): path parameters in curly braces (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* feat(api-usage-monitoring-filter): realms via global config and client pattern on filter level (incompatible interface change) (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* feat(api-usage-monitoring-filter): improvements proposed by @tkrop (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* feat(api-usage-monitoring-filter): use regex for realms to track (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 25, 2019
@maxim-tschumak
fix(apiusagemonitoring): create noop filter in case of invalid config (…
cbde191 
…zalando#949)
@maxim-tschumak maxim-tschumak mentioned this issue Feb 25, 2019
Merged
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 25, 2019
@maxim-tschumak
fix(apiusagemonitoring): create noop filter in case of invalid config (…
1cf8a9f 
…zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
aryszka pushed a commit that referenced this issue Feb 25, 2019
@maxim-tschumak @aryszka
fix(apiusagemonitoring): create noop filter in case of invalid config (…
04b0e77 
…#949) (#966)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit to maxim-tschumak/skipper that referenced this issue Feb 25, 2019
@maxim-tschumak
fix(apiusagemonitoring): add doc info about no-op filter in case of i…
71380ec 
…nvalid config (zalando#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
@maxim-tschumak maxim-tschumak mentioned this issue Feb 25, 2019
Merged
szuecs pushed a commit that referenced this issue Feb 25, 2019
@maxim-tschumak @szuecs
fix(apiusagemonitoring): add doc info about no-op filter in case of i…
699645f 
…nvalid config (#949) (#967)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): remove deprecated parameter (#949)
f376407 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
@maxim-tschumak maxim-tschumak mentioned this issue Apr 11, 2019
Merged
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): remove deprecated parameter (#949)
0915699 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): remove deprecated parameter (#949)
74556f9 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): warning in log if deprecated para…
1b29788 
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): warning in log if deprecated para…
48d384d 
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): warning in log if deprecated para…
f8dd553 
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 11, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): warning in log if deprecated para…
0d784b5 
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 15, 2019
@maxim-tschumak
chore(apiusagemonitoring-filter): add warning (deprecated default cli…
ae96c03 
…ent tracking pattern) for library users (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 15, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): remove deprecated parameter (#949)
aa3190e 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 15, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): warning in log if deprecated para…
52bb01d 
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 15, 2019
@maxim-tschumak
chore(apiusagemonitoring-filter): add warning (deprecated default cli…
2e3d2a7 
…ent tracking pattern) for library users (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 16, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): add deprecation comment (#949)
0d92f6f 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 17, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): remove deprecated parameter (#949)
d113c44 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 17, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): warning in log if deprecated para…
382f3ee 
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 17, 2019
@maxim-tschumak
chore(apiusagemonitoring-filter): add warning (deprecated default cli…
8c57221 
…ent tracking pattern) for library users (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak added a commit that referenced this issue Apr 17, 2019
@maxim-tschumak
chore(api-usage-monitoring filter): add deprecation comment (#949)
c35844b 
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
aryszka pushed a commit that referenced this issue Apr 24, 2019
@maxim-tschumak @aryszka
chore(api-usage-monitoring filter): remove deprecated parameter (#949) (
d8cad64 
#1029)

* chore(api-usage-monitoring filter): remove deprecated parameter (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* chore(api-usage-monitoring filter): warning in log if deprecated parameter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* chore(apiusagemonitoring-filter): add warning (deprecated default client tracking pattern) for library users (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>

* chore(api-usage-monitoring filter): add deprecation comment (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxim-tschumak