Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api-usage-monitoring filter): remove deprecated parameter (#949) #1029

Merged

Conversation

maxim-tschumak
Copy link
Contributor

Related to #949 - cleaning up an unused deprecated parameter.

Signed-off-by: Maxim Tschumak maxim.tschumak@gmail.com

@maxim-tschumak maxim-tschumak force-pushed the 949-clean-up-deprecated-default-client-tracking-pattern branch from f376407 to 0915699 Compare April 11, 2019 10:13
@tkrop
Copy link
Member

tkrop commented Apr 11, 2019

👍

@maxim-tschumak maxim-tschumak force-pushed the 949-clean-up-deprecated-default-client-tracking-pattern branch from 0915699 to 74556f9 Compare April 11, 2019 10:52
skipper.go Outdated Show resolved Hide resolved
@maxim-tschumak maxim-tschumak force-pushed the 949-clean-up-deprecated-default-client-tracking-pattern branch 3 times, most recently from f8dd553 to 0d784b5 Compare April 11, 2019 13:26
@maxim-tschumak maxim-tschumak force-pushed the 949-clean-up-deprecated-default-client-tracking-pattern branch from ae96c03 to 2e3d2a7 Compare April 15, 2019 07:53
skipper.go Outdated Show resolved Hide resolved
@szuecs
Copy link
Member

szuecs commented Apr 16, 2019

@maxim-tschumak only a minor nit.
@aryszka this is ready to review

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
…meter is used (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
…ent tracking pattern) for library users (#949)

Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
@maxim-tschumak maxim-tschumak force-pushed the 949-clean-up-deprecated-default-client-tracking-pattern branch from 0d92f6f to c35844b Compare April 17, 2019 10:02
@maxim-tschumak
Copy link
Contributor Author

👍

1 similar comment
@aryszka
Copy link
Contributor

aryszka commented Apr 24, 2019

👍

@szuecs
Copy link
Member

szuecs commented Apr 24, 2019

👍

1 similar comment
@aryszka
Copy link
Contributor

aryszka commented Apr 24, 2019

👍

@aryszka aryszka merged commit d8cad64 into master Apr 24, 2019
@aryszka aryszka deleted the 949-clean-up-deprecated-default-client-tracking-pattern branch April 24, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants