Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excplict set of GOPROXY #1256

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Remove excplict set of GOPROXY #1256

merged 1 commit into from
Dec 13, 2019

Conversation

miry
Copy link
Contributor

@miry miry commented Dec 12, 2019

The default setting for GOPROXY is "https://proxy.golang.org,direct" since go version 1.13.
With current implementation, the option direct is missing, that is fallback to original sources.

@miry miry marked this pull request as ready for review December 13, 2019 09:22
The default setting for GOPROXY is "https://proxy.golang.org,direct" since go version 1.13.
With current implementation, the option direct is missing, that is fallback to original sources.

Signed-off-by: Michael Nikitochkin <miry.sof@gmail.com>
@aryszka
Copy link
Contributor

aryszka commented Dec 13, 2019

👍

1 similar comment
@szuecs
Copy link
Member

szuecs commented Dec 13, 2019

👍

@szuecs szuecs merged commit d38db5e into zalando:master Dec 13, 2019
@miry miry deleted the goproxy-default branch December 13, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants