filters/scheduler: refactor fifo tests #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AlexanderYastrebov
commented
Oct 19, 2023
AlexanderYastrebov
commented
- separate argument tests from behaviour test
- use eskip to define filter configuration
- use TestFifo prefix for all test names
AlexanderYastrebov
force-pushed
the
filters/scheduler/refactor-fifo-test
branch
2 times, most recently
from
bc81632
to
bf0131a
Compare
szuecs
reviewed
Oct 19, 2023
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
filters/scheduler/refactor-fifo-test
branch
from
bf0131a
to
0e8f73a
Compare
|
👍 |
szuecs
reviewed
Oct 19, 2023
| // logrus.Info("histogram reporter:") | ||
| // histReporter := vegeta.NewHistogramReporter(atk.metrics.Histogram) | ||
| // histReporter.Report(os.Stdout) | ||
| log.Print("text reporter:") |
There was a problem hiding this comment.
is this related to refactoring fifo tests?
There was a problem hiding this comment.
Vegeta Attacker is used by the tests and I saw this stray log message so decided to fix it right away.
|
👍 |
szuecs
pushed a commit
that referenced
this pull request
Nov 7, 2023
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Nov 27, 2023
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Nov 27, 2023
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Nov 27, 2023
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.