phc: test multiple unhealthy endpoints #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
|
👍 |
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
|
we were able to fix with custom options for endpointregistry but still with the minimum value race still fails |
szuecs
reviewed
May 6, 2024
szuecs
reviewed
May 6, 2024
szuecs
reviewed
May 6, 2024
szuecs
reviewed
May 6, 2024
… tricky to set different headers for attacks Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
force-pushed
the
phc/refactor-tests-and-add-extra
branch
from
3b66e9c
to
281ba57
Compare
MustafaSaber
commented
May 7, 2024
| }) | ||
| }) | ||
| } | ||
|
|
||
| t.Run("consistentHash", func(t *testing.T) { |
There was a problem hiding this comment.
ConsistentHash was separated and using old approach because it's a little bit tricky to set headers for different set of requests with Vegeta, we use the hash to map the request to endpoint.
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
|
👍 |
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
|
👍 |
1 similar comment
|
👍 |
This was referenced May 13, 2024
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
use vegeta with all algorithms except `consistentHash` as it's a bit tricky to set different headers for attacks Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3035
With multiple unhealthy endpoints test case fails