Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a ID generation issue when a single ingress contains two hostnames that would collide given the previous
routeID
function.The problem was caused because of the sanitization rule, that replaced any non-word with an underscore. Given
my-api.prd.company.com
andmy-api-prd.company.com
, they would be sanitized to the same name,my_api_prd_company_com
.Somewhere down the code, one would effectively replace the other rule, allowing only one of the domains to be actually registered. (probably by putting the routes on a map using
eskip.Route.Id
as key)My solution was to include the index of the ingress
host
in the name. Anything else that could make the ID unique would work as well (hashing, etc)