-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rule 127 - Use JSON as payload data interchange format #1225
Conversation
I'm not sure, but may be this implementation is going to far, since we explicitly relax this rule in #168. |
@tkrop thanks for the comment. My impression was that in these cases API designers have to exclude Rule 167 explicitly. From API perspective it is hard to distinguish where should be JSON and where something else. |
@vadeg Yes, I agree. Excluding rules is definitely an option. However, currently we do not encourage the usage of |
Let's discuss this on our meeting. |
We decided not to implement this rule, because this would lead many exceptions and it would be difficult to validate each case. |
May be you can separate 38da19a, so that we can merge this quickly. |
The build seems to be failing because of the same reason as in #1227:
|
Fixes #1217
085a25c
to
fac1cce
Compare
hint: we discussed / decided the topic in the API guild meeting --> see https://docs.google.com/document/d/1NahSuMC0LRwFTTrln2m0iDLq0nHzGmF59Gv7xBhKPfQ/edit#bookmark=id.p63ihhuscg86 |
Instead of this, we want #1316. |
Implement Rule 167
Fixes #1217