Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Bearer security schema support #1227

Merged
merged 3 commits into from
May 27, 2021
Merged

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Apr 23, 2021

  • Add a Bearer security schema support
  • Clean up the code

Fixes #1096

Comment on lines 73 to 81
schema.isOAuth2() -> {
validateOAuth2Schema(
context,
op,
operationScopes,
schema,
schemaName
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brackets are not necessary - which may improve readability here.

@tkrop
Copy link
Member

tkrop commented May 20, 2021

👍

@tkrop
Copy link
Member

tkrop commented May 20, 2021

May be we need to investigate why the build failed before merging:

=== RUN   TestIntegrationWithNoMustViolations
--- FAIL: TestIntegrationWithNoMustViolations (0.33s)
    integration_test.go:84: 
        	Error Trace:	integration_test.go:84
        	Error:      	Should be zero, but was 9
        	Test:       	TestIntegrationWithNoMustViolations
        	Messages:   	No MUST violations expected
    integration_test.go:88: 
        	Error Trace:	integration_test.go:88
        	Error:      	Expected nil, but got: &domain.AppError{e:(*errors.errorString)(0xc000167050), c:3}
        	Test:       	TestIntegrationWithNoMustViolations
`

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #1227 (294f8a4) into master (69c8cee) will not change coverage.
The diff coverage is n/a.

❗ Current head 294f8a4 differs from pull request most recent head 68418ef. Consider uploading reports for the commit 68418ef to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1227   +/-   ##
=========================================
  Coverage     87.62%   87.62%           
  Complexity       85       85           
=========================================
  Files            69       69           
  Lines           978      978           
  Branches         71       71           
=========================================
  Hits            857      857           
  Misses           84       84           
  Partials         37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c8cee...68418ef. Read the comment docs.

@vadeg
Copy link
Contributor Author

vadeg commented May 20, 2021

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented May 27, 2021

👍

@tkrop tkrop merged commit 0a8ddb5 into master May 27, 2021
@tkrop tkrop deleted the gh-1096-add-bearer-support branch May 27, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refinement of security section using OpenAPI 3
3 participants