RuleValidator changes as requested by @tkrop #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxspring
requested review from
maschleg,
maxim-tschumak and
netme
as code owners
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
=========================================
Coverage 84.58% 84.58%
- Complexity 905 909 +4
=========================================
Files 145 145
Lines 2335 2335
Branches 307 306 -1
=========================================
Hits 1975 1975
Misses 223 223
Partials 137 137
Continue to review full report at Codecov.
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuleValidator changes as requested by @tkrop