Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-JSON values #60

Closed
alexkuz opened this issue Feb 23, 2016 · 7 comments
Closed

Support non-JSON values #60

alexkuz opened this issue Feb 23, 2016 · 7 comments

Comments

@alexkuz
Copy link
Contributor

alexkuz commented Feb 23, 2016

The extension serializes state with jsan, losing values like undefined or function.

The way to fix this is to use node-stringify / eval, instead of jsan.stringify / jsan.parse.
(there is probably a better option than eval, I'm not sure) :)

@zalmoxisus
Copy link
Owner

I guess node-stringify will not support circular references. Before jsan we've also used circular-json and json-stringify-safe, but jsan seems to be faster than competitors.

I think we better add that in jsan as @kolodny uses our extension and will accept a PR (?)

@alexkuz
Copy link
Contributor Author

alexkuz commented Feb 23, 2016

Oh, that seems better, indeed.

@kolodny
Copy link

kolodny commented Feb 24, 2016

@zalmoxisus @alexkuz I wrote a helper function to do this, let me know if it solves your use case

kolodny/jsan#1 (comment)

@zalmoxisus
Copy link
Owner

@alexkuz, you can try it in 1.0.0.8. Thanks a lot, @kolodny!

Also added redux-devtools-inspector monitor in #64.

zalmoxisus added a commit that referenced this issue Mar 1, 2016
@alexkuz
Copy link
Contributor Author

alexkuz commented Mar 1, 2016

@zalmoxisus thank you!

@zalmoxisus
Copy link
Owner

@alexkuz, unfortunately, I've temporally reverted it due to #67.

@zalmoxisus
Copy link
Owner

Should work well now. Thanks to everybody for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants