The extension shouldn't affect the performance when no monitors are opened #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalmoxisus
added a commit
that referenced
this pull request
Mar 9, 2016
The extension shouldn't affect the performance when no monitors are opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Chrome restrictions, the extension is not allowed to communicate with the app's script directly, so we relay every change to the background script. By introducing new features in #60, the serialization for every change becomes slower, which is a problem when having a lot of data in states.
We want the extension not to process the changes while it is not required as most of the time we don't monitor the changes.
The problem is to support simultaneous instances in this scenario, so we need to change the way of messaging by using long-lived connections.