-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gpu): fix sample extraction when nth > 0 and keep input unchanged #1425
Conversation
a53a7b5
to
d3ea654
Compare
d3ea654
to
b2e01f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pdroalves! Thank you very much for this. I have some comments on the PR but mainly a question: shouldn't we apply sample extraction to a list of GLWE ciphertexts and output a list of LWE ciphertexts? That would be more efficient for the compression of a vector of inputs, which is what we'll need if I'm correct. Then you don't need to add types for CudaGlweCiphertext and CudaLweCiphertext, you can reuse the existing List types.
249a7f0
to
40ee415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pdroalves! Thanks a lot for this PR 🙂 I just have some small comments about it, after that it'll be good to go!
40ee415
to
a6fda27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Thanks!
This PR:
nth > 0
,We might also observe another performance improvement.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/671
PR content/description
Check-list: