Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editstart and editend events for cell editors. #11

Merged
merged 4 commits into from
Jan 10, 2017

Conversation

gabrielmontagne
Copy link
Contributor

Motivation and Context

It's useful to know when a cell action starts and ends -- one might, for example, suspend streaming prices while the grid is in edit mode.
This change provides a pair of edit start/end events to support this.

How Was This Tested?

On a rig from a pre-release version, 0.6.0-editstart-editend.1 published to NPM.
http://bl.ocks.org/gabrielmontagne/f83bfda1e29501cbcd3a7ed820e18a2a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change follows the style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the contribution guidelines
  • I have added tests to cover my changes
  • All new and existing tests passed

@gabrielmontagne gabrielmontagne merged commit 5c6557b into master Jan 10, 2017
@gabrielmontagne gabrielmontagne deleted the edit-start-edit-end-events-work branch January 10, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants