Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the "pinned row" concept to use a predicate instead of a property #21

Merged
merged 3 commits into from
Oct 12, 2016

Conversation

cristiano-belloni
Copy link
Contributor

Description

Allow predicates instead of pinned property.

Motivation and Context

In order to make the grid more configurable, we expanded the concept of "pinned row" to use a predicate that says if the row is always shown, even when the parent is collapsed or not. This is built on top of #18 and it will behave the same (i.e. it will support one level of depth)

How Was This Tested?

Manually, see this updated gist.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change follows the style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the contribution guidelines
  • I have added tests to cover my changes
  • All new and existing tests passed

Copy link
Contributor

@gabrielmontagne gabrielmontagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. : )
The change is very simple and easy to read.

@gabrielmontagne gabrielmontagne merged commit fc5676e into master Oct 12, 2016
@gabrielmontagne gabrielmontagne deleted the pinned-predicate-work branch October 12, 2016 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants