refactor: storageClassName field in values.yaml and statefulset spec #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
mirrors https://github.com/bitnami/charts/blob/4a75dde3b6722b2783cd123da9c2e7ceb92f7a66/bitnami/common/templates/_storage.tpl Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
…storageClassName Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
monotek
requested changes
Oct 15, 2021
BREAKING CHANGES * values.yaml changes require a new major version Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
|
superseeded by: #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR converges the notation for the storageClassName field with those from for example bitnami, due to the outlined cases in #96 by @nervo.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer: This change is rather small, but it still introduces breaking changes for existing values.yaml files, does it deserve anything else than a patch due to its size?
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]