Refactoring: Removed unnecessary OnlineNotification.seen method.

zammad · Sep 5, 2019 · 0afb105 · 0afb105
1 parent 9c76def
commit 0afb105
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 19 deletions.
diff --git a/app/controllers/online_notifications_controller.rb b/app/controllers/online_notifications_controller.rb
@@ -174,9 +174,9 @@ def destroy
   def mark_all_as_read
     notifications = OnlineNotification.list(current_user, 200)
     notifications.each do |notification|
-      if !notification['seen']
-        OnlineNotification.seen(id: notification['id'])
-      end
+      next if notification['seen']
+
+      OnlineNotification.find(notification['id']).update!(seen: true)
     end
     render json: {}, status: :ok
   end

diff --git a/app/models/online_notification.rb b/app/models/online_notification.rb
@@ -61,22 +61,6 @@ def self.add(data)
 
 =begin
 
-mark online notification as seen
-
-  OnlineNotification.seen(
-    id: 2,
-  )
-
-=end
-
-  def self.seen(data)
-    notification = OnlineNotification.find(data[:id])
-    notification.seen = true
-    notification.save
-  end
-
-=begin
-
 remove whole online notifications of an object
 
   OnlineNotification.remove('Ticket', 123)