Fixes #4831 - Invited colleagues during setup always get Agent role

app/assets/javascripts/app/controllers/getting_started/agent.coffee

@@ -46,17 +46,11 @@ class GettingStartedAgent extends App.ControllerWizardFullScreen
   submit: (e) =>
     e.preventDefault()
     @formDisable(e)
-    @params          = @formParam(e.target)
-    @params.role_ids = []
 
+    @params = @formParam(e.target)
     # set invite flag
     @params.invite = true
 
-    # find agent role
-    role = App.Role.findByAttribute('name', 'Agent')
-    if role
-      @params.role_ids = role.id
-
     user = new App.User
     user.load(@params)
 

spec/system/getting_started/agents_spec.rb

@@ -17,4 +17,21 @@
         .to have_text("Email address 'admin@example.com' is already used for another user.")
     end
   end
+
+  it 'adds roles correctly' do
+    visit 'getting_started/agents', skip_waiting: true
+
+    fill_in 'email', with: 'test@example.com'
+
+    click 'span', text: 'Admin'
+    click 'span', text: 'Agent' # unselect preselected role
+    click '.btn--success'
+
+    expect(User.last).to have_attributes(
+      email: 'test@example.com',
+      roles: contain_exactly(
+        Role.find_by(name: 'Admin')
+      )
+    )
+  end
 end