Follow-up cffdc2c - Fixes #4875 - Translation Management Improvements.

zammad · Mar 25, 2024 · 6e066c4 · 6e066c4
1 parent f469434
commit 6e066c4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/app/assets/javascripts/app/controllers/translation.coffee b/app/assets/javascripts/app/controllers/translation.coffee
@@ -329,18 +329,14 @@ class TranslationModal extends App.ControllerModal
       url: "#{@apiPath}/translations/upsert",
       data: JSON.stringify(params),
       processData: true,
-      success: =>
+      success: (data) =>
         @close()
         @successCallback()
 
-        # Show toast if neeeded (means that in string inside the current user language was changed).
         # Later we should add real subscription handling for this situation in the new tech stack.
         currentLocale = App.i18n.get()
         if params.locale == currentLocale
-          @notify(
-            type: 'success'
-            msg:  App.i18n.translateContent('To see the updated translation, please reload your browser.')
-          )
+          App.i18n.setMap(data.source, data.target)
 
     })
 

diff --git a/app/services/service/translation/upsert.rb b/app/services/service/translation/upsert.rb
@@ -15,7 +15,8 @@ def execute
     translation = Translation.find_source(locale, source)
 
     if translation
-      return translation.update!(target: target)
+      translation.update!(target: target)
+      return translation
     end
 
     Translation.create!(locale: locale, source: source, target: target, is_synchronized_from_codebase: false)

diff --git a/i18n/zammad.pot b/i18n/zammad.pot
@@ -13887,10 +13887,6 @@ msgstr ""
 msgid "To revert back to the default payload, simply turn off the \"Custom Payload\" switch above."
 msgstr ""
 
-#: app/assets/javascripts/app/controllers/translation.coffee
-msgid "To see the updated translation, please reload your browser."
-msgstr ""
-
 #: app/assets/javascripts/app/models/text_module.coffee
 msgid "To select placeholders from a list, just enter \"::\"."
 msgstr ""