Fixes #5101 - Fetching LdapSource for unknown users fails.

zammad · Apr 23, 2024 · c5266fa · c5266fa
1 parent 979314a
commit c5266fa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/app/models/ldap_source.rb b/app/models/ldap_source.rb
@@ -10,6 +10,7 @@ class LdapSource < ApplicationModel
   store :preferences
 
   def self.by_user(user)
+    return if user.blank? || user.source.blank?
     return if !%r{^Ldap::(\d+)$}.match?(user.source)
 
     LdapSource.find(user.source.split('::')[1])

diff --git a/spec/lib/sequencer/unit/import/common/user/skip/is_ldap_source_spec.rb b/spec/lib/sequencer/unit/import/common/user/skip/is_ldap_source_spec.rb
@@ -46,5 +46,17 @@
         expect(result).not_to include(action: :skipped)
       end
     end
+
+    context 'when user is empty' do
+      let(:user) { nil }
+
+      it 'does not skip' do
+        result = process({
+                           instance: user,
+                         })
+
+        expect(result).not_to include(action: :skipped)
+      end
+    end
   end
 end