Maintenance: Improved translatable strings.

Co-authored-by: Martin Gruner <mg@zammad.com> Co-authored-by: Dusan Vuckovic <dv@zammad.com>
zammad · Jan 25, 2024 · db33c5c · db33c5c
1 parent 443a4c5
commit db33c5c
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/app/frontend/apps/desktop/components/CommonSelect/CommonSelect.vue b/app/frontend/apps/desktop/components/CommonSelect/CommonSelect.vue
@@ -332,7 +332,7 @@ const duration = VITE_TEST_MODE ? undefined : { enter: 300, leave: 200 }
                 @keypress.enter.prevent.stop="selectAll()"
                 @keypress.space.prevent.stop="selectAll()"
               >
-                {{ $t('select all') }}
+                {{ $t('select all options') }}
               </CommonLabel>
             </div>
             <div

diff --git a/app/frontend/apps/desktop/components/Form/fields/FieldSelect/__tests__/FieldSelect.spec.ts b/app/frontend/apps/desktop/components/Form/fields/FieldSelect/__tests__/FieldSelect.spec.ts
@@ -739,7 +739,7 @@ describe('Form - Field - Select - Features', () => {
     const menu = wrapper.getByRole('menu')
 
     let selectAllButton = getByRole(menu, 'button', {
-      name: 'select all',
+      name: 'select all options',
     })
 
     const listbox = getByRole(menu, 'listbox')
@@ -826,7 +826,7 @@ describe('Form - Field - Select - Features', () => {
     })
 
     selectAllButton = getByRole(menu, 'button', {
-      name: 'select all',
+      name: 'select all options',
     })
 
     expect(selectAllButton).toBeInTheDocument()
@@ -1138,7 +1138,9 @@ describe('Form - Field - Select - Accessibility', () => {
 
     const menu = wrapper.getByRole('menu')
 
-    const selectAllButton = getByRole(menu, 'button', { name: 'select all' })
+    const selectAllButton = getByRole(menu, 'button', {
+      name: 'select all options',
+    })
 
     expect(selectAllButton).toHaveAttribute('tabindex', '1')
 

diff --git a/...tend/apps/desktop/components/Form/fields/FieldTreeSelect/FieldTreeSelectInputDropdown.vue b/...tend/apps/desktop/components/Form/fields/FieldTreeSelect/FieldTreeSelectInputDropdown.vue
@@ -459,7 +459,9 @@ const duration = VITE_TEST_MODE ? undefined : { enter: 300, leave: 200 }
                 @keypress.space.prevent.stop="selectAll()"
               >
                 {{
-                  currentPath.length ? $t('select visible') : $t('select all')
+                  currentPath.length
+                    ? $t('select visible options')
+                    : $t('select all options')
                 }}
               </CommonLabel>
             </div>

diff --git a/...end/apps/desktop/components/Form/fields/FieldTreeSelect/__tests__/FieldTreeSelect.spec.ts b/...end/apps/desktop/components/Form/fields/FieldTreeSelect/__tests__/FieldTreeSelect.spec.ts
@@ -664,7 +664,7 @@ describe('Form - Field - TreeSelect - Features', () => {
     const menu = wrapper.getByRole('menu')
 
     const selectAllButton = getByRole(menu, 'button', {
-      name: 'select all',
+      name: 'select all options',
     })
 
     const listbox = getByRole(menu, 'listbox')
@@ -774,7 +774,7 @@ describe('Form - Field - TreeSelect - Features', () => {
 
     expect(
       queryByRole(menu, 'button', {
-        name: 'select visible',
+        name: 'select visible options',
       }),
     ).not.toBeInTheDocument()
 
@@ -791,7 +791,7 @@ describe('Form - Field - TreeSelect - Features', () => {
     })
 
     const selectVisibleButton = getByRole(menu, 'button', {
-      name: 'select visible',
+      name: 'select visible options',
     })
 
     await wrapper.events.click(selectVisibleButton)
@@ -1256,7 +1256,9 @@ describe('Form - Field - TreeSelect - Accessibility', () => {
 
     const menu = wrapper.getByRole('menu')
 
-    const selectAllButton = getByRole(menu, 'button', { name: 'select all' })
+    const selectAllButton = getByRole(menu, 'button', {
+      name: 'select all options',
+    })
 
     expect(selectAllButton).toHaveAttribute('tabindex', '2')
 

diff --git a/i18n/zammad.pot b/i18n/zammad.pot
@@ -15889,7 +15889,7 @@ msgstr ""
 
 #: app/frontend/apps/desktop/components/CommonSelect/CommonSelect.vue
 #: app/frontend/apps/desktop/components/Form/fields/FieldTreeSelect/FieldTreeSelectInputDropdown.vue
-msgid "select all"
+msgid "select all options"
 msgstr ""
 
 #: app/assets/javascripts/app/views/generic/attachment.jst.eco
@@ -15898,7 +15898,7 @@ msgid "select attachment…"
 msgstr ""
 
 #: app/frontend/apps/desktop/components/Form/fields/FieldTreeSelect/FieldTreeSelectInputDropdown.vue
-msgid "select visible"
+msgid "select visible options"
 msgstr ""
 
 #: app/assets/javascripts/app/controllers/_ui_element/core_workflow_perform.coffee