Fixes: Mobile - Cannot add new files, if FieldFile is disabled

zammad · Mar 17, 2023 · ec7d3d2 · ec7d3d2
1 parent 21ca6f6
commit ec7d3d2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/app/frontend/shared/components/Form/fields/FieldFile/FieldFileInput.vue b/app/frontend/shared/components/Form/fields/FieldFile/FieldFileInput.vue
@@ -39,7 +39,10 @@ const removeFileMutation = new MutationHandler(
 const removeFileLoading = addFileMutation.loading()
 
 const canInteract = computed(
-  () => !addFileLoading.value && !removeFileLoading.value,
+  () =>
+    !props.context.disabled &&
+    !addFileLoading.value &&
+    !removeFileLoading.value,
 )
 
 const fileInput = ref<HTMLInputElement>()

diff --git a/app/frontend/shared/components/Form/fields/FieldFile/__tests__/FieldFile.spec.ts b/app/frontend/shared/components/Form/fields/FieldFile/__tests__/FieldFile.spec.ts
@@ -238,4 +238,20 @@ describe('Fields - FieldFile', () => {
       'file is removed',
     ).not.toBeInTheDocument()
   })
+
+  it('cannot add file, if the field is disabled', async () => {
+    const view = renderFileInput({
+      multiple: true,
+      value: [],
+      disabled: true,
+    })
+
+    const clickEvent = vi.fn()
+    HTMLInputElement.prototype.click = clickEvent
+
+    const fileButton = view.getByRole('button', { name: 'Attach files' })
+    expect(fileButton).toBeDisabled()
+    await view.events.click(fileButton)
+    expect(clickEvent).not.toHaveBeenCalled()
+  })
 })