Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Till label not assigned to corresponding input fields in calendar edit view #3793

Closed
saz opened this issue Oct 7, 2021 · 6 comments
Closed

Comments

@saz
Copy link

saz commented Oct 7, 2021

Infos:

  • Used Zammad version: 5.0.x
  • Installation method (source, package, ..): source
  • Operating system: Ubuntu 18.04
  • Database + version: Postgresql 9.6
  • Elasticsearch version: 7.15.0
  • Browser + version: Google Chrome 92.0.4515.131

Expected behavior:

  • Clicking on a Till label in the calendar edit view activates the corresponding input field

Actual behavior:

  • Clicking on a Till label in the calendar edit view activates the Monday input field in all cases
    image

Steps to reproduce the behavior:

  • Clicking on a Till label

Yes I'm sure this is a bug and no feature request or a general question.

@MrGeneration
Copy link
Member

Can't reproduce, seems to be a local issue.
Please ensure you've run all required steps during the upgrade / installation as per documentation.

If that doesn't help and still persists, please consult the community: https://community.zammad.org

@regiohelden-dev
Copy link

regiohelden-dev commented Oct 7, 2021

Weird... Because it's in the code:

<label for="monday_end_time">till</label>

@saz
Copy link
Author

saz commented Oct 7, 2021

@MrGeneration Mind reopening this bug report?

@MrGeneration
Copy link
Member

I agree on the label being invalid (since 2015):
image

However, I cannot reprodce Chrome v94 using mondays till on all other values - neither on updating nor on creating:
image
image
image

I'm also not seeing mentioned console errors:
image

The last two parts are the reason why the issue has been flagged with can't reproduce.
Please ensure that this is not a browser addon feature striking into the UI.

I did verify this on:

  • (clean) hosted environment
  • (clean) package installation

I also did ensure Cache of Zammad being cleared and even went through the trouble to recompile the assets.
I also double tab above comments on Firefox v92.

So as for the functionality described I can't reproduce this and thus currently have to expect local issues (combinations of things). However, do agree on the label needing a proper fix which -under the hood- probably will fix your "local" issue as well.

@saz
Copy link
Author

saz commented Oct 7, 2021

Interestingly enough, I'm not getting this message in the console, but the HTML is still wrong.
If you're clicking on any of the words TILL the time input field below this word will be focused?

@MrGeneration
Copy link
Member

You're right, when clicking on till the wrong field is highlighted. So that's definitely an issue.

dantronik-bugreporting added a commit to dantronik-bugreporting/zammad that referenced this issue Oct 12, 2021
@rolfschmidt rolfschmidt self-assigned this Nov 26, 2021
@rolfschmidt rolfschmidt added this to To do in OLD Workflow via automation Nov 26, 2021
@rolfschmidt rolfschmidt added this to the 5.0.3 milestone Nov 26, 2021
@rolfschmidt rolfschmidt moved this from To do to In progress in OLD Workflow Nov 26, 2021
zammad-sync pushed a commit that referenced this issue Nov 26, 2021
@rolfschmidt rolfschmidt moved this from In progress to Done in OLD Workflow Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
OLD Workflow
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants