Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error on editing textareas admin object manager attributes #3889

Closed
rolfschmidt opened this issue Dec 13, 2021 · 8 comments
Closed

JS error on editing textareas admin object manager attributes #3889

rolfschmidt opened this issue Dec 13, 2021 · 8 comments

Comments

@rolfschmidt
Copy link
Collaborator

rolfschmidt commented Dec 13, 2021

Infos:

  • Used Zammad version: 5.0.2-1638282353.9435da0a.buster amd64
  • Installation method (source, package, ..): packages
  • Operating system: Debian 10
  • Database + version: MariaDB 10.3.31-0+deb10u1
  • Elasticsearch version: 7.10.2
  • Browser + version: Safari 15?0, Firefox 94.0.2

Expected behavior:

  • Can not edit field Address (textarea) in object manager attributes.

Actual behavior:

I don't know whether or not this is related, but I suspect it is, when I click on Address property of User in Objects manager, nothing happens, but the following JS error :

image

Originally posted by @benrubson in #3878 (comment)

Steps to reproduce:

-> Open Admin -> Objects
-> Switch to tab User
-> Open field "Address"
-> js error in console.

@rolfschmidt
Copy link
Collaborator Author

rolfschmidt commented Dec 13, 2021

@benrubson pls try in the future to NOT put multiple topics in one issue.

@benrubson
Copy link
Contributor

@rolfschmidt, sure, sorry for this, as I thought they were related I did not open 2 different issues 😕
Anyway, thank you for your consideration into this 👍

@rolfschmidt
Copy link
Collaborator Author

Hi @benrubson

does this issue still occur to you? I know back then I got it once but it does not seem to be reproducible (also tried the old commit) any more hm... The only thing I have at the moment is that the text area is too small which I could fix then also.

@benrubson
Copy link
Contributor

Hi @rolfschmidt,
Unfortunately yes, still reproductible, for example clicking on the default Address property of the User object.
I'm running last version (5.0.3-1641391411.7adc0a12.buster).
Tested in both Safari and Firefox.
Feel free if you need more debug info 👍

@rolfschmidt
Copy link
Collaborator Author

@benrubson does it happen every time to you? What are the excactly steps? I tried it look at my video:

screen-recorder-thu-jan-06-2022-13-41-46.mov

I could not reproduce it in a new workflow, saved worfklow and on a hosted system of us with firefox. Don't have safari tho. I remember that I had this issue also last year, but I forgot how to get the error.

@benrubson
Copy link
Contributor

@rolfschmidt I see, we are not in the same place :)
So in #3878 I asked to add organization and address as action for the User object, in Core Workflow.

But here, in #3889, error is not in Core Workflow, but in Admin > System > Objects.
Then go into User object manager, and click on Address to edit this property.
Nothing will happen, and the JS error will trigger.
(I first mentioned this in #3878 because this may be the cause of address not appearing as action for the User object, in Core Workflow, they may be related...)

@rolfschmidt
Copy link
Collaborator Author

ah okay I got you sorry!

Steps to reproduce:
-> Open Admin -> Objects
-> Switch to tab User
-> Open field "Address"
-> js error in console.

@benrubson
Copy link
Contributor

Yep, that's it 👍

@rolfschmidt rolfschmidt changed the title Core Workflow: JS error on selecting textareas in conditions of User object JS error on editing textareas admin object manager attributes Jan 6, 2022
@rolfschmidt rolfschmidt added this to the 5.1 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants