change working directory #2509
Closed
change working directory #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running as cron, pg_dump might complain about permissions in the current working directory. changing directory to the BACKUP_SCRIPT_PATH solves this.
MrGeneration
added
needs verification
works as designed / wontfix
and removed
needs verification
labels
|
Thanks for your contribution! As already mentioned in #2508 I personally don't see this as a real problem, as you should rather work with the crontab of the Zammad-User instead of root. I will therefor not merge this pull request, as I don't see the benefit (no offense!). |
|
@monotek I just saw that you reopened this PR. So you think we should merge it? What do we need to do next? |
thorsteneckel
added
needs verification
waiting for feedback
and removed
works as designed / wontfix
labels
MrGeneration
reviewed
Jul 8, 2019
|
closed by accident - re-open |
Optimized when we run the change dir, because we only need it if everything is good to go. I'll now add a remark internally so that I won't to it a fourth time.
|
@thorsteneckel this is ready for merging. :-) |
|
We currently can't merge PRs from Github, this is why I'm closing this PR for the sake of our internal MR no. 866 Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2508
When running as cron, pg_dump might complain about permissions in the current working directory.
changing directory to the BACKUP_SCRIPT_PATH solves this.