Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form style for customer-input consistent #3886

Closed
wants to merge 1 commit into from
Closed

Conversation

xf-
Copy link
Contributor

@xf- xf- commented Dec 9, 2021

Set parameters like color and background with form-control class.

This template uses the form-control it as well without a problem.
https://github.com/zammad/zammad/blob/develop/app/assets/javascripts/app/views/layout_ref/chat_to_ticket.jst.eco

Before
image

After
image

I entered the field, so you can see the position from complete is fine.

(The line end was done by GitHub editor)

Set parameters like color and background with form-control class.
@MrGeneration
Copy link
Member

Can you please let us know which browser you verified this on?
I can't seem to reproduce this on a current Google Chrome.

@xf-
Copy link
Contributor Author

xf- commented Dec 9, 2021

I use Firefox Linux Dark Theme system setting & browser, but the issue is only on dark themes.

Without a style it fallsback to system style. This is only field without a defined color and background-color.

There are multiple addons to help with it, but because most are set and one has no value i get a mix of fields.
https://addons.mozilla.org/en-US/firefox/addon/text-contrast-for-dark-themes/

OR
https://addons.mozilla.org/en-US/firefox/addon/fix-dark-theme-input-boxes

@MrGeneration
Copy link
Member

Without being able to further qualify your PR (from my end), please keep in mind:
We have to control over browser and addon behavior. If you use manipulation tools to change UI appearance, this is out of the core's scope.

A developer will have a look any way as soon as there's time.

@xf-
Copy link
Contributor Author

xf- commented Dec 9, 2021

No, the Add-ons trys to fix it. The issue appears in a vanilla installed browser. I wanted to show, it is a more or less common issue with dark theme and not perfect websites.

Input field normally in zammad
image

This special field - Customer select
image

Organization field - Edit Customer has form-control - same autocompelte stuff
image

Every Field in zammad has this class to get the same input behavior except this one.

If you have a dark theme the page without any style is dark with a light font and in this case everything is set white background and dark font EXCEPT this one field.

@MrGeneration
Copy link
Member

Thank you for the clarification!

@xf-
Copy link
Contributor Author

xf- commented Dec 9, 2021

Chrome uses a base stylesheet that has a light theme in a dark setup. Firefox provides a dark theme.

Good example - no style page
https://wiki.selfhtml.org/extensions/Selfhtml/example.php/Beispiel:Html5_grundger%C3%BCst.html

Firefox/Chrome
image

@dominikklein dominikklein changed the title Make form style for customer-inout consistent Make form style for customer-input consistent Jan 5, 2022
@rolfschmidt rolfschmidt self-assigned this Jan 13, 2022
@rolfschmidt rolfschmidt reopened this Jan 13, 2022
@rolfschmidt
Copy link
Collaborator

rolfschmidt commented Jan 13, 2022

thx for your support @xf- ... backport is following

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants