Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Fix knowledge base spacing and layout #3987

Closed

Conversation

rotimiazeez
Copy link
Contributor

Issue Description

Knowledge Base should have the same layout and spacing from LTR and RTL.
The knowledge base UI has an unwanted gap.

Issue Link#3925

Proposed Solution

The CSS property padding-left for the ul and ol elements in the knowledge_base.scss is moving the component of the page causing the gap, setting it to 0 should fix the issue.

Screenshots

Before

zammad1
zammad2

After

  • RTL
    screenshot (3)
    screenshot (1)

  • LTR
    screenshot (4)
    screenshot (2)

Code Changes

  • Modify knowledge_base.scss file

Note: There might be possible regression I don't know of but I tried to check and there's none known to my knowledge

@dominikklein dominikklein self-assigned this Mar 10, 2022
@dominikklein
Copy link
Collaborator

Hi @rotimiazeez

thanks for you contribution. This PR is now merged with above commit.

Best regards,
Dominik

@rotimiazeez
Copy link
Contributor Author

Hi @dominikklein 👋🏽,

Thanks for the review, it's a pleasure contributing to this awesome codebase 🤓.
I hope to do more 👍🏽.

Best regards,
Azeez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants