This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Add assignCreditToUploader option when pushing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-sl-eng
force-pushed
the
rhbz1184299
branch
2 times, most recently
from
b33e4b4
to
b1f2dd5
Compare
| @@ -50,6 +50,14 @@ public Person getTranslator() { | |||
| return translator; | |||
| } | |||
|
|
|||
| @Deprecated | |||
| /** | |||
| * Zanata server will ignore this field if set, | |||
There was a problem hiding this comment.
I did not remember this being part of the criteria we decided, so I looked for the criteria and could not find any. Did we really decide to make the translator field not work?
@aeng What criteria are you using to implement this?
@djansen-redhat What criteria will you be using to verify this?
There was a problem hiding this comment.
We never used this field at all. To simplify implementation on server, this should be deprecated.
There was a problem hiding this comment.
Cool, if we never used it then it is fine to deprecate.
alex-sl-eng
force-pushed
the
rhbz1184299
branch
from
b1f2dd5
to
519214b
Compare
|
👍 |
alex-sl-eng
force-pushed
the
rhbz1184299
branch
from
519214b
to
c4715f2
Compare
alex-sl-eng
force-pushed
the
rhbz1184299
branch
from
c4715f2
to
43b9108
Compare
alex-sl-eng
changed the title
alex-sl-eng
changed the title
|
Merged into integration/master. 86e0008 |
This was referenced Feb 2, 2015
alex-sl-eng
force-pushed
the
rhbz1184299
branch
from
95e7001
to
2835bcc
Compare
|
Merged into integration/master. bb9f2c7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1184299
See also:
Server: zanata/zanata-server#678
Client: zanata/zanata-client#46
DO NOT MERGE UNTIL Zanata-Server implementation is done.