This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
rely on content not content state when determine what can be omitted in push #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return input == null | ||
| || input.getContents().isEmpty() | ||
| || all(input.getContents(), | ||
| blankStringPredicate); |
There was a problem hiding this comment.
what about the input.getState().isUntranslated(); condition?
There was a problem hiding this comment.
It's not reliable when dealing with plural entries. We treat it as untranslated if not all plurals have value. Therefore the original implementation will miss some partial translations
|
👍 |
huangp
pushed a commit
that referenced
this pull request
Apr 23, 2015
rely on content not content state when determine what can be omitted in push
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with plural entries, the content state is not always reliable.