This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
/
TransUnitsTablePresenterTest.java
468 lines (390 loc) · 17.9 KB
/
TransUnitsTablePresenterTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
package org.zanata.webtrans.client.presenter;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import java.util.Collections;
import java.util.List;
import net.customware.gwt.presenter.client.EventBus;
import org.hamcrest.Matchers;
import org.mockito.ArgumentCaptor;
import org.mockito.InOrder;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
import org.zanata.common.ContentState;
import org.zanata.model.TestFixture;
import org.zanata.webtrans.client.events.FilterViewEvent;
import org.zanata.webtrans.client.events.LoadingEvent;
import org.zanata.webtrans.client.events.NotificationEvent;
import org.zanata.webtrans.client.events.RefreshPageEvent;
import org.zanata.webtrans.client.events.TableRowSelectedEvent;
import org.zanata.webtrans.client.events.TransUnitSaveEvent;
import org.zanata.webtrans.client.events.TransUnitSelectionEvent;
import org.zanata.webtrans.client.resources.WebTransMessages;
import org.zanata.webtrans.client.service.NavigationService;
import org.zanata.webtrans.client.service.TransUnitSaveService;
import org.zanata.webtrans.client.service.TranslatorInteractionService;
import org.zanata.webtrans.client.view.SourceContentsDisplay;
import org.zanata.webtrans.client.view.TargetContentsDisplay;
import org.zanata.webtrans.client.view.TransUnitsTableDisplay;
import org.zanata.webtrans.shared.auth.EditorClientId;
import org.zanata.webtrans.shared.model.TransHistoryItem;
import org.zanata.webtrans.shared.model.TransUnit;
import org.zanata.webtrans.shared.model.TransUnitId;
import org.zanata.webtrans.shared.rpc.TransUnitUpdated;
import com.google.common.collect.Lists;
/**
* @author Patrick Huang <a href="mailto:pahuang@redhat.com">pahuang@redhat.com</a>
*/
@Test(groups = "unit-tests")
public class TransUnitsTablePresenterTest
{
private TransUnitsTablePresenter presenter;
@Mock
private TransUnitsTableDisplay display;
@Mock
private EventBus eventBus;
@Mock
private NavigationService navigationService;
@Mock
private SourceContentsPresenter sourceContentsPresenter;
@Mock
private TargetContentsPresenter targetContentsPresenter;
@Mock
private TranslatorInteractionService translatorService;
@Mock
private TransUnitSaveService saveService;
@Mock
private WebTransMessages messages;
@Mock
private TranslationHistoryPresenter translationHistoryPresenter;
@BeforeMethod
public void setUp() throws Exception
{
MockitoAnnotations.initMocks(this);
presenter = new TransUnitsTablePresenter(display, eventBus, navigationService, sourceContentsPresenter, targetContentsPresenter, translatorService, saveService, translationHistoryPresenter, messages);
verify(display).setRowSelectionListener(presenter);
verify(display).addFilterConfirmationHandler(presenter);
verify(navigationService).addPageDataChangeListener(presenter);
verify(eventBus).addHandler(TransUnitSaveEvent.TYPE, saveService);
}
@Test
public void onBind()
{
presenter.onBind();
verify(eventBus).addHandler(FilterViewEvent.getType(), presenter);
verify(eventBus).addHandler(TransUnitSelectionEvent.getType(), presenter);
verify(eventBus).addHandler(TableRowSelectedEvent.TYPE, presenter);
verify(eventBus).addHandler(LoadingEvent.TYPE, presenter);
}
@Test
public void onTransUnitSelected()
{
// Given:
TransUnit selection = TestFixture.makeTransUnit(1);
TransUnitSelectionEvent transUnitSelectionEvent = new TransUnitSelectionEvent(selection);
// When:
presenter.onTransUnitSelected(transUnitSelectionEvent);
// Then:
verify(sourceContentsPresenter).setSelectedSource(selection.getId());
verify(targetContentsPresenter).setSelected(selection.getId());
verify(translatorService).transUnitSelected(selection);
}
@Test
public void onGoToPage()
{
presenter.goToPage(2);
verify(targetContentsPresenter).savePendingChangesIfApplicable();
verify(navigationService).gotoPage(1);
}
@Test
public void onFilterViewEventDoNothingIfItsCancel()
{
presenter.onFilterView(new FilterViewEvent(true, true, true, true));
verifyNoMoreInteractions(eventBus, display, targetContentsPresenter);
}
@Test
public void onFilterViewEventWillShowConfirmationIfHasUnsavedContent()
{
// Given: current editor content has changed
when(targetContentsPresenter.currentEditorContentHasChanged()).thenReturn(true);
// When: not a cancel event
presenter.onFilterView(new FilterViewEvent(true, false, true, false));
// Then:
verify(display).showFilterConfirmation();
}
@Test
public void onFilterViewEventWillHideConfirmationAndDoFilter()
{
// Given: current edtior hasn't changed
when(targetContentsPresenter.currentEditorContentHasChanged()).thenReturn(false);
FilterViewEvent event = new FilterViewEvent(true, false, true, false);
// When:
presenter.onFilterView(event);
// Then:
verify(display).hideFilterConfirmation();
verify(navigationService).execute(event);
}
@Test
public void onSaveChangeAndFilter()
{
when(targetContentsPresenter.getCurrentTransUnitIdOrNull()).thenReturn(new TransUnitId(1));
presenter.saveChangesAndFilter();
verify(targetContentsPresenter).saveCurrent(ContentState.Approved);
verify(display).hideFilterConfirmation();
verify(navigationService).execute(Mockito.isA(FilterViewEvent.class));
}
@Test
public void onSaveAsFuzzyAndFilter()
{
when(targetContentsPresenter.getCurrentTransUnitIdOrNull()).thenReturn(new TransUnitId(1));
presenter.saveAsFuzzyAndFilter();
verify(targetContentsPresenter).saveCurrent(ContentState.NeedReview);
verify(display).hideFilterConfirmation();
verify(navigationService).execute(Mockito.isA(FilterViewEvent.class));
}
@Test
public void onDiscardChangeAndFilter()
{
TransUnitId currentId = new TransUnitId(1);
when(targetContentsPresenter.getCurrentTransUnitIdOrNull()).thenReturn(currentId);
presenter.discardChangesAndFilter();
verify(targetContentsPresenter).onCancel(currentId);
verify(display).hideFilterConfirmation();
verify(navigationService).execute(Mockito.isA(FilterViewEvent.class));
}
@Test
public void onCancelFilter()
{
presenter.cancelFilter();
ArgumentCaptor<FilterViewEvent> filterViewEventCaptor = ArgumentCaptor.forClass(FilterViewEvent.class);
verify(eventBus).fireEvent(filterViewEventCaptor.capture());
assertThat(filterViewEventCaptor.getValue().isCancelFilter(), Matchers.equalTo(true));
verify(display).hideFilterConfirmation();
}
@Test
public void canShowDataOnCurrentPage()
{
List<TransUnit> transUnits = Lists.newArrayList(TestFixture.makeTransUnit(1));
List<TargetContentsDisplay> targetContentsDisplays = Lists.newArrayList();
List<SourceContentsDisplay> sourceContentsDisplays = Lists.newArrayList();
when(targetContentsPresenter.getDisplays()).thenReturn(targetContentsDisplays);
when(sourceContentsPresenter.getDisplays()).thenReturn(sourceContentsDisplays);
presenter.showDataForCurrentPage(transUnits);
verify(sourceContentsPresenter).showData(transUnits);
verify(targetContentsPresenter).showData(transUnits);
verify(display).buildTable(sourceContentsDisplays, targetContentsDisplays);
}
@Test
public void canRefreshRowIfNotOnCurrentSelection()
{
// Given: coming updated ID is NOT equal to current selected id and is from another user
EditorClientId editorClientId = new EditorClientId("session", 1);
when(translatorService.getCurrentEditorClientId()).thenReturn(editorClientId);
TransUnit updatedTransUnit = TestFixture.makeTransUnit(1);
presenter.setStateForTesting(new TransUnitId(99));
// When: update type is save and done by different user
presenter.refreshRow(updatedTransUnit, new EditorClientId("session", 2), TransUnitUpdated.UpdateType.WebEditorSave);
// Then:
verify(targetContentsPresenter).updateRow(updatedTransUnit);
verifyZeroInteractions(eventBus);
verifyNoMoreInteractions(targetContentsPresenter);
}
@Test
public void refreshRowFromCurrentUserWillGetIgnored()
{
// Given: coming client id is the same as current user
EditorClientId editorClientId = new EditorClientId("session", 1);
when(translatorService.getCurrentEditorClientId()).thenReturn(editorClientId);
TransUnit updatedTransUnit = TestFixture.makeTransUnit(1);
presenter.setStateForTesting(updatedTransUnit.getId());
// When: refreshRow from same user
presenter.refreshRow(updatedTransUnit, editorClientId, TransUnitUpdated.UpdateType.WebEditorSaveFuzzy);
// Then:
verifyZeroInteractions(eventBus, targetContentsPresenter);
}
@Test
public void willRefreshRowFromCurrentUserNotAsEditorSave()
{
// Given: coming client id is the same as current user
EditorClientId editorClientId = new EditorClientId("session", 1);
when(translatorService.getCurrentEditorClientId()).thenReturn(editorClientId);
TransUnit updatedTransUnit = TestFixture.makeTransUnit(1);
presenter.setStateForTesting(updatedTransUnit.getId());
// When: refreshRow from same user but update type is replace
presenter.refreshRow(updatedTransUnit, editorClientId, TransUnitUpdated.UpdateType.ReplaceText);
// Then:
verify(targetContentsPresenter).updateRow(updatedTransUnit);
verifyZeroInteractions(eventBus);
verifyNoMoreInteractions(targetContentsPresenter);
}
@Test
public void willDetectSaveDoneByAnotherUserAndCurrentUserDoNotHaveUnsavedChange()
{
// Given: coming client id is NOT current user
EditorClientId currentUser = new EditorClientId("session1", 1);
when(translatorService.getCurrentEditorClientId()).thenReturn(currentUser);
TransUnit updatedTransUnit = TestFixture.makeTransUnit(1);
presenter.setStateForTesting(updatedTransUnit.getId());
when(messages.concurrentEdit()).thenReturn("concurrent edit detected");
// current user does not have unsaved change
when(targetContentsPresenter.currentEditorContentHasChanged()).thenReturn(false);
// When: update type is save fuzzy
presenter.refreshRow(updatedTransUnit, new EditorClientId("session2", 2), TransUnitUpdated.UpdateType.WebEditorSaveFuzzy);
// Then:
ArgumentCaptor<NotificationEvent> eventCaptor = ArgumentCaptor.forClass(NotificationEvent.class);
verify(eventBus).fireEvent(eventCaptor.capture());
assertThat(eventCaptor.getValue().getMessage(), Matchers.equalTo("concurrent edit detected"));
verify(targetContentsPresenter).currentEditorContentHasChanged();
verify(targetContentsPresenter).updateRow(updatedTransUnit);
verifyNoMoreInteractions(targetContentsPresenter);
verifyZeroInteractions(translationHistoryPresenter);
}
@Test
public void willDetectSaveDoneByAnotherUserAndCurrentUserHasUnsavedChange()
{
// Given: coming client id is NOT current user
EditorClientId currentUser = new EditorClientId("session1", 1);
when(translatorService.getCurrentEditorClientId()).thenReturn(currentUser);
TransUnit updatedTransUnit = TestFixture.makeTransUnit(1);
presenter.setStateForTesting(updatedTransUnit.getId());
when(messages.concurrentEdit()).thenReturn("concurrent edit detected");
when(messages.concurrentEditTitle()).thenReturn("please resolve conflict");
// current user does not have unsaved change
when(targetContentsPresenter.currentEditorContentHasChanged()).thenReturn(true);
// When: update type is save fuzzy
presenter.refreshRow(updatedTransUnit, new EditorClientId("session2", 2), TransUnitUpdated.UpdateType.WebEditorSaveFuzzy);
// Then:
ArgumentCaptor<NotificationEvent> eventCaptor = ArgumentCaptor.forClass(NotificationEvent.class);
verify(eventBus).fireEvent(eventCaptor.capture());
assertThat(eventCaptor.getValue().getMessage(), Matchers.equalTo("concurrent edit detected"));
ArgumentCaptor<TransHistoryItem> transHistoryCaptor = ArgumentCaptor.forClass(TransHistoryItem.class);
InOrder inOrder = Mockito.inOrder(targetContentsPresenter, translationHistoryPresenter);
inOrder.verify(translationHistoryPresenter).popupAndShowLoading("please resolve conflict");
inOrder.verify(translationHistoryPresenter).displayEntries(transHistoryCaptor.capture(), eq(Collections.<TransHistoryItem>emptyList()));
assertThat(transHistoryCaptor.getValue().getVersionNum(), Matchers.equalTo(updatedTransUnit.getVerNum().toString()));
assertThat(transHistoryCaptor.getValue().getContents(), Matchers.equalTo(updatedTransUnit.getTargets()));
inOrder.verify(targetContentsPresenter).updateRow(updatedTransUnit);
}
@Test
public void canHighlightSearch()
{
presenter.highlightSearch("blah");
verify(targetContentsPresenter).highlightSearch("blah");
verify(sourceContentsPresenter).highlightSearch("blah");
}
@Test
public void onRowSelected()
{
// Given: current row index is 1
when(navigationService.getCurrentRowIndexOnPage()).thenReturn(1);
// When: select row index 2
presenter.onRowSelected(2);
// Then:
verify(targetContentsPresenter).savePendingChangesIfApplicable();
verify(navigationService).selectByRowIndex(2);
verify(display).applySelectedStyle(2);
}
@Test
public void willDoNothingIfSelectSameRow()
{
// Given: current row index is 1
when(navigationService.getCurrentRowIndexOnPage()).thenReturn(1);
// When: select row index is also 1
presenter.onRowSelected(1);
// Then:
verify(navigationService).getCurrentRowIndexOnPage();
verifyNoMoreInteractions(navigationService);
verifyZeroInteractions(targetContentsPresenter, display);
}
@Test
public void onTableRowSelectingSameRow()
{
// Given: selecting id is on row index 2, and current selected row index is also 2
TransUnitId selectingId = new TransUnitId(1);
when(navigationService.findRowIndexById(selectingId)).thenReturn(2);
when(navigationService.getCurrentRowIndexOnPage()).thenReturn(2);
// When:
presenter.onTableRowSelected(new TableRowSelectedEvent(selectingId));
// Then:
verify(navigationService).getCurrentRowIndexOnPage();
verifyZeroInteractions(targetContentsPresenter);
}
@Test
public void onTableRowSelectingDifferentRow()
{
// Given: selecting id is on row index 2, and current selected row index is 3
TransUnitId selectingId = new TransUnitId(1);
when(navigationService.findRowIndexById(selectingId)).thenReturn(2);
when(navigationService.getCurrentRowIndexOnPage()).thenReturn(3);
// When:
presenter.onTableRowSelected(new TableRowSelectedEvent(selectingId));
// Then:
verify(navigationService, times(2)).getCurrentRowIndexOnPage();
verify(targetContentsPresenter).savePendingChangesIfApplicable();
verify(navigationService).selectByRowIndex(2);
verify(display).applySelectedStyle(2);
}
@Test
public void onLoadingEvent()
{
presenter.onLoading(LoadingEvent.START_EVENT);
verify(display).showLoading(true);
presenter.onLoading(LoadingEvent.FINISH_EVENT);
verify(display).showLoading(false);
}
@Test
public void canRefreshViewWithSearch()
{
// Given: presenter has highlight search term
presenter.highlightSearch("blah");
TargetContentsDisplay targetDisplay = mock(TargetContentsDisplay.class);
SourceContentsDisplay sourceDisplay = mock(SourceContentsDisplay.class);
// assuming two displays in the list
List<TargetContentsDisplay> targetContentsDisplays = Lists.newArrayList(targetDisplay, targetDisplay);
List<SourceContentsDisplay> sourceContentsDisplays = Lists.newArrayList(sourceDisplay, sourceDisplay);
when(targetContentsPresenter.getDisplays()).thenReturn(targetContentsDisplays);
when(sourceContentsPresenter.getDisplays()).thenReturn(sourceContentsDisplays);
// When:
presenter.refreshView();
// Then:
verify(sourceDisplay, times(2)).refresh();
verify(targetDisplay, times(2)).refresh();
verify(sourceDisplay, times(2)).highlightSearch("blah");
verify(targetDisplay, times(2)).highlightSearch("blah");
}
@Test
public void canRefreshViewWithNoSearch()
{
// Given: presenter has no highlight search term
TargetContentsDisplay targetDisplay = mock(TargetContentsDisplay.class);
SourceContentsDisplay sourceDisplay = mock(SourceContentsDisplay.class);
// assuming two displays in the list
List<TargetContentsDisplay> targetContentsDisplays = Lists.newArrayList(targetDisplay, targetDisplay);
List<SourceContentsDisplay> sourceContentsDisplays = Lists.newArrayList(sourceDisplay, sourceDisplay);
when(targetContentsPresenter.getDisplays()).thenReturn(targetContentsDisplays);
when(sourceContentsPresenter.getDisplays()).thenReturn(sourceContentsDisplays);
// When:
presenter.refreshView();
// Then:
verify(sourceDisplay, times(2)).refresh();
verify(targetDisplay, times(2)).refresh();
verify(sourceDisplay, never()).highlightSearch(anyString());
verify(targetDisplay, never()).highlightSearch(anyString());
}
@Test
public void onRefreshPageEvent()
{
presenter.onRefreshPage(RefreshPageEvent.REFRESH_CODEMIRROR_EVENT);
verify(display).delayRefresh();
}
}