Add unit test for TransUnitNavigationService

zanata · May 15, 2012 · 02f4d0a · 02f4d0a
1 parent 0ea8e6b
commit 02f4d0a
Show file tree

Hide file tree

Showing 4 changed files with 200 additions and 11 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/TableConstants.java b/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/TableConstants.java
@@ -2,6 +2,6 @@
 
 public class TableConstants
 {
-   static final int PAGE_SIZE = 50;
+   public static final int PAGE_SIZE = 50;
    static final int MAX_PAGE_ROW = PAGE_SIZE - 1;
 }
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/TableEditorPresenter.java b/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/TableEditorPresenter.java
@@ -207,7 +207,7 @@ private void initialiseTransUnitsNavigation()
          @Override
          public void onSuccess(GetTransUnitsNavigationResult result)
          {
-            navigationService.init(result.getTransIdStateList(), result.getIdIndexList());
+            navigationService.init(result.getTransIdStateList(), result.getIdIndexList(), display.getPageSize());
          }
 
          @Override
@@ -223,7 +223,6 @@ protected void onBind()
    {
       display.setTableModelHandler(tableModelHandler);
       display.setPageSize(TableConstants.PAGE_SIZE);
-      navigationService.setPageSize(display.getPageSize());
 
       registerHandler(filterViewConfirmationPanel.getSaveChangesAndFilterButton().addClickHandler(new ClickHandler()
       {

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/service/TransUnitNavigationService.java b/zanata-war/src/main/java/org/zanata/webtrans/client/service/TransUnitNavigationService.java
@@ -70,13 +70,14 @@ public boolean apply(ContentState contentState)
    private ArrayList<Long> idIndexList;
 
    private int pageSize;
-   private int curRowIndex;
-   private int curPage;
+   private int curRowIndex = 0;
+   private int curPage = 0;
 
-   public void init(Map<Long, ContentState> transIdStateList, ArrayList<Long> idIndexList)
+   public void init(Map<Long, ContentState> transIdStateList, ArrayList<Long> idIndexList, int pageSize)
    {
       this.transIdStateList = transIdStateList;
       this.idIndexList = idIndexList;
+      this.pageSize = pageSize;
    }
 
    public void updateMap(Long id, ContentState newState)
@@ -168,9 +169,4 @@ public int getPrevRowIndex()
    {
       return curRowIndex - 1;
    }
-
-   public void setPageSize(int pageSize)
-   {
-      this.pageSize = pageSize;
-   }
 }
diff --git a/...-war/src/test/java/org/zanata/webtrans/client/service/TransUnitNavigationServiceTest.java b/...-war/src/test/java/org/zanata/webtrans/client/service/TransUnitNavigationServiceTest.java
@@ -0,0 +1,194 @@
+package org.zanata.webtrans.client.service;
+
+import static org.junit.Assert.assertEquals;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+import org.zanata.common.ContentState;
+import org.zanata.webtrans.TestFixture;
+import org.zanata.webtrans.client.editor.table.TableConstants;
+import org.zanata.webtrans.shared.model.TransUnit;
+
+import com.google.common.collect.Lists;
+
+@Test(groups = { "unit-tests" })
+public class TransUnitNavigationServiceTest
+{
+   private TransUnitNavigationService navigationService;
+   private final List<TransUnit> tuList = Lists.newArrayList(
+       TestFixture.makeTransUnit(0, ContentState.New),
+       TestFixture.makeTransUnit(1, ContentState.New),
+       TestFixture.makeTransUnit(2, ContentState.NeedReview),
+       TestFixture.makeTransUnit(3, ContentState.Approved),
+       TestFixture.makeTransUnit(4, ContentState.NeedReview),
+       TestFixture.makeTransUnit(5, ContentState.New),
+       TestFixture.makeTransUnit(6, ContentState.NeedReview),
+       TestFixture.makeTransUnit(7, ContentState.Approved),
+       TestFixture.makeTransUnit(8, ContentState.New),
+       TestFixture.makeTransUnit(9, ContentState.New),
+       TestFixture.makeTransUnit(10, ContentState.NeedReview)
+);
+
+   @BeforeMethod
+   protected void setUp() throws Exception
+   {
+      navigationService = new TransUnitNavigationService();
+      HashMap<Long, ContentState> transIdStateList = new HashMap<Long, ContentState>();
+      ArrayList<Long> idIndexList = new ArrayList<Long>();
+
+      for (TransUnit tu : tuList)
+      {
+         transIdStateList.put(tu.getId().getId(), tu.getStatus());
+         idIndexList.add(tu.getId().getId());
+      }
+      navigationService.init(transIdStateList, idIndexList, TableConstants.PAGE_SIZE);
+   }
+
+   @Test
+   public void testGetInitialPageSize()
+   {
+      assertEquals(navigationService.getCurrentPage(), 0);
+   }
+
+   @Test
+   public void testGetInitialRowIndex()
+   {
+      assertEquals(navigationService.getCurrentRowIndex(), 0);
+   }
+
+   @Test
+   public void testGetNextRowIndex()
+   {
+      assertEquals(navigationService.getNextRowIndex(), 1);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 3);
+      assertEquals(navigationService.getCurrentRowIndex(), 3);
+      assertEquals(navigationService.getNextRowIndex(), 4);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 5);
+      assertEquals(navigationService.getCurrentRowIndex(), 5);
+      assertEquals(navigationService.getNextRowIndex(), 6);
+
+   }
+
+   @Test
+   public void testGetPrevRowIndex()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 1);
+      assertEquals(navigationService.getCurrentRowIndex(), 1);
+      assertEquals(navigationService.getPrevRowIndex(), 0);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 4);
+      assertEquals(navigationService.getCurrentRowIndex(), 4);
+      assertEquals(navigationService.getPrevRowIndex(), 3);
+   }
+
+   @Test
+   public void testGetRowIndex()
+   {
+      assertEquals(navigationService.getRowIndex(tuList.get(0), false, tuList), new Integer(0));
+
+      assertEquals(navigationService.getRowIndex(tuList.get(1), true, tuList), new Integer(1));
+      assertEquals(navigationService.getRowIndex(tuList.get(2), false, tuList), new Integer(2));
+
+   }
+
+   @Test
+   public void testGetPreviousStateRowIndexNewAndFuzzy()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 9);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 8);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 8);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 6);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 4);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 2);
+   }
+
+   @Test
+   public void testGetPreviousStateRowIndexNew()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 9);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.NEW_PREDICATE), 8);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 8);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.NEW_PREDICATE), 5);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 0);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.NEW_PREDICATE), 0);
+
+   }
+
+   @Test
+   public void testGetPreviousStateRowIndexFuzzy()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 9);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_PREDICATE), 6);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 6);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_PREDICATE), 4);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 3);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_PREDICATE), 2);
+   }
+
+   @Test
+   public void testGetNextStateRowIndexNewAndFuzzy()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 2);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 4);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 4);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 5);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 7);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 8);
+   }
+
+   @Test
+   public void testGetNextStateRowIndexNew()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 0);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.NEW_PREDICATE), 1);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 5);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.NEW_PREDICATE), 8);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 9);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.NEW_PREDICATE), 9);
+
+   }
+
+   @Test
+   public void testGetNextStateRowIndexFuzzy()
+   {
+      navigationService.updateCurrentPageAndRowIndex(0, 0);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_PREDICATE), 2);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 3);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_PREDICATE), 4);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 10);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_PREDICATE), 10);
+   }
+
+   @Test
+   public void testUpdateMapAndNavigate()
+   {
+      navigationService.updateMap(new Long(9), ContentState.Approved);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 10);
+      assertEquals(navigationService.getPreviousStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 8);
+
+      navigationService.updateMap(new Long(3), ContentState.NeedReview);
+
+      navigationService.updateCurrentPageAndRowIndex(0, 2);
+      assertEquals(navigationService.getNextStateRowIndex(TransUnitNavigationService.FUZZY_OR_NEW_PREDICATE), 3);
+   }
+
+}