rhbz860128 - should not report error code when editor lose connection…

… on save
zanata · Nov 27, 2012 · 950ed6e · 950ed6e
1 parent 5d203cb
commit 950ed6e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/service/TransUnitSaveService.java b/zanata-war/src/main/java/org/zanata/webtrans/client/service/TransUnitSaveService.java
@@ -119,7 +119,7 @@ private boolean stateHasNotChanged(TransUnitSaveEvent event)
       {
          return false;
       }
-      Log.info(transUnit.getId() + " old contents: " + transUnit.getTargets() + " state: " + transUnit.getStatus());
+      Log.info("id:" + transUnit.getId() + " old contents: " + transUnit.getTargets() + " state: " + transUnit.getStatus());
       return Objects.equal(transUnit.getStatus(), event.getAdjustedStatus()) && Objects.equal(transUnit.getTargets(), event.getTargets());
    }
 
@@ -146,7 +146,7 @@ public UpdateTransUnitCallback(TransUnitSaveEvent event, TransUnitId id)
       public void onFailure(Throwable e)
       {
          Log.error("UpdateTransUnit failure ", e);
-         saveFailure(e.getMessage());
+         saveFailure();
       }
 
       @Override
@@ -172,19 +172,19 @@ public void onSuccess(UpdateTransUnitResult result)
          }
          else
          {
-            saveFailure("id " + id);
+            saveFailure();
          }
          if (queue.hasPending())
          {
             performSave(id);
          }
       }
 
-      private void saveFailure(String message)
+      private void saveFailure()
       {
          queue.removeAllPending(event.getTransUnitId());
          targetContentsPresenter.setEditingState(event.getTransUnitId(), TargetContentsDisplay.EditingState.UNSAVED);
-         eventBus.fireEvent(new NotificationEvent(NotificationEvent.Severity.Error, messages.notifyUpdateFailed(message), goToRowLink));
+         eventBus.fireEvent(new NotificationEvent(NotificationEvent.Severity.Error, messages.notifyUpdateFailed("id " + id), goToRowLink));
       }
    }
 }
diff --git a/zanata-war/src/test/java/org/zanata/webtrans/client/service/TransUnitSaveServiceTest.java b/zanata-war/src/test/java/org/zanata/webtrans/client/service/TransUnitSaveServiceTest.java
@@ -283,7 +283,7 @@ public void onPRCFailure()
 
       // Then: will reset value back
       AsyncCallback<UpdateTransUnitResult> callback = resultCaptor.getValue();
-      when(messages.notifyUpdateFailed("doh")).thenReturn("update failed");
+      when(messages.notifyUpdateFailed("id " + TRANS_UNIT_ID)).thenReturn("update failed");
       callback.onFailure(new RuntimeException("doh"));
       verify(targetContentsPresenter).setEditingState(saveEvent.getTransUnitId(), TargetContentsDisplay.EditingState.UNSAVED);
       ArgumentCaptor<NotificationEvent> notificationEventCaptor = ArgumentCaptor.forClass(NotificationEvent.class);