Work in progress: plural support - cancel button

zanata · Mar 23, 2012 · a1ccf2c · a1ccf2c
1 parent f98a678
commit a1ccf2c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 18 deletions.
diff --git a/...nata-war/src/main/java/org/zanata/webtrans/client/editor/table/TargetContentsDisplay.java b/...nata-war/src/main/java/org/zanata/webtrans/client/editor/table/TargetContentsDisplay.java
@@ -35,6 +35,8 @@ interface Listener
       void toggleView(ToggleEditor editor);
 
       void setValidationMessagePanel(ToggleEditor editor);
+
+      void onCancel(ToggleEditor editor);
    }
 
    void setTargets(List<String> targets);

diff --git a/...ta-war/src/main/java/org/zanata/webtrans/client/editor/table/TargetContentsPresenter.java b/...ta-war/src/main/java/org/zanata/webtrans/client/editor/table/TargetContentsPresenter.java
@@ -20,9 +20,6 @@
 
 import javax.inject.Provider;
 
-import com.google.common.base.Preconditions;
-import com.google.common.base.Predicate;
-import com.google.common.collect.Collections2;
 import net.customware.gwt.presenter.client.EventBus;
 
 import org.zanata.webtrans.client.events.CopyDataToEditorEvent;
@@ -31,20 +28,23 @@
 import org.zanata.webtrans.client.events.InsertStringInEditorHandler;
 import org.zanata.webtrans.client.events.NavTransUnitEvent;
 import org.zanata.webtrans.client.events.NotificationEvent;
+import org.zanata.webtrans.client.events.NotificationEvent.Severity;
 import org.zanata.webtrans.client.events.RequestValidationEvent;
 import org.zanata.webtrans.client.events.RequestValidationEventHandler;
 import org.zanata.webtrans.client.events.RunValidationEvent;
 import org.zanata.webtrans.client.events.UpdateValidationWarningsEvent;
 import org.zanata.webtrans.client.events.UpdateValidationWarningsEventHandler;
-import org.zanata.webtrans.client.events.NotificationEvent.Severity;
 import org.zanata.webtrans.client.presenter.SourceContentsPresenter;
-import org.zanata.webtrans.client.resources.NavigationMessages;
 import org.zanata.webtrans.client.resources.TableEditorMessages;
 import org.zanata.webtrans.client.ui.ToggleEditor;
+import org.zanata.webtrans.client.ui.ToggleEditor.ViewMode;
 import org.zanata.webtrans.client.ui.ValidationMessagePanel;
 import org.zanata.webtrans.shared.model.TransUnit;
 
 import com.allen_sauer.gwt.log.client.Log;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Predicate;
+import com.google.common.collect.Collections2;
 import com.google.common.collect.Lists;
 import com.google.inject.Inject;
 import com.google.inject.Singleton;
@@ -233,6 +233,11 @@ public void saveAsApproved(ToggleEditor editor)
          eventBus.fireEvent(new NavTransUnitEvent(NavTransUnitEvent.NavigationType.NextEntry));
       }
    }
+
+   @Override
+   public void onCancel(ToggleEditor editor) {
+      editor.setViewMode(ViewMode.VIEW);
+   }
 
    @Override
    public void copySource(ToggleEditor editor)

diff --git a/server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/Editor.java b/server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/Editor.java
@@ -84,8 +84,6 @@ public Editor(String displayString, String findMessage, final TargetContentsDisp
 
       fuzzyButton.addClickHandler(fuzzyHandler);
 
-      cancelButton.addClickHandler(cancelHandler);
-
       label.setText(displayString);
       if (displayString == null || displayString.isEmpty())
       {
@@ -192,6 +190,14 @@ public void onSaveAsApproved(ClickEvent event)
       listener.saveAsApproved(this);
       event.stopPropagation();
    }
+
+   @UiHandler("cancelButton")
+   public void onCancel(ClickEvent event)
+   {
+      listener.onCancel(this);
+      event.stopPropagation();
+   }
+
 
    @UiHandler("label")
    public void onLabelClick(ClickEvent event)
@@ -253,17 +259,6 @@ public void onClick(ClickEvent event)
       }
    };
 
-   /**
-    * The click listener used to cancel.
-    */
-   private ClickHandler cancelHandler = new ClickHandler()
-   {
-      public void onClick(ClickEvent event)
-      {
-         // cancelEdit();
-      }
-   };
-
    /**
     * The click listener used to accept.
     */