Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pong timeout firing after close? #773

Open
carlcook opened this issue Nov 9, 2018 · 0 comments
Open

Pong timeout firing after close? #773

carlcook opened this issue Nov 9, 2018 · 0 comments

Comments

@carlcook
Copy link

carlcook commented Nov 9, 2018

Hi,

I suspect the pong timeout handler has a minor issue.

This is the scenario (reproducible):

  1. Create a web socket server
  2. Specify a pong timeout handler
  3. Connect a client to this server
  4. Send the client a ping
  5. The client disconnects (remotely) prior to the pong being sent to the server
  6. Unfortunately, the pong timeout still fires, with a valid connection handle (i.e. shared_ptr.lock returns non-null, even though the client has been closed).

I'd expect for the pong timeout handler to not fire in this scenario.

If you agree that this is an issue, I'm happy enough at trying to create a PR.

Thanks,
Carl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant