fix(cli) tie example apps to package version #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all versions of the CLI pulled from the master branch when making example apps. This was good because we could fixes to the example apps would be available right away. Less good because example apps might conflict with released versions of the CLI.
This came to a head when I merged #124 and the build broke. Two main issues:
zapier init --template typescript
andzapier build
. Now, this test was running using the master branch'stypescript
template but publishedcore@9.0.0
. Because that PR changed the TS configuration, the definitions in core were incompatible and it threw an error.Pinning examples to releases means slower bug fixes (which are infrequent anyway), but more control (and the ability to make breaking changes in the templates without affecting versions in the wild).