fix(core) use NodeJS ReadableStream instead of DOM in TS definitions #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaznovac
commented
Dec 13, 2019
kaznovac
commented
- use NodeJS.ReadableStream instead of ReadableStream from DOM
- set node tsconfig recommended settings for node 10.x in example app
- explicitly provide only es2018 lib in tsconfig (to avoid accidental importing of DOM modules)
* set node tsconfig recommended settings for node 10.x * explicitly provide only es2018 lib in tsc (to avoid accidental importing of DOM modules)
|
this is node-fetch typings for reference about ReadableStream https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node-fetch/index.d.ts |
xavdid
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.