Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORTESC-101] docs(cli): Change 90-day limit for callbacks to 30-day #293

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

armchairlinguist
Copy link
Contributor

We believe that due to tasks no longer being saved for 90 days, a callback posting after 30 days has a risk of failing, so the documentation should state 30 days as the max.

@armchairlinguist armchairlinguist changed the title docs(cli): Change 90-day limit for callbacks to 30-day [SUPPORTESC-100] docs(cli): Change 90-day limit for callbacks to 30-day Dec 3, 2020
@armchairlinguist armchairlinguist changed the title [SUPPORTESC-100] docs(cli): Change 90-day limit for callbacks to 30-day [SUPPORTESC-101] docs(cli): Change 90-day limit for callbacks to 30-day Dec 3, 2020
@eliangcs
Copy link
Member

eliangcs commented Dec 4, 2020

@codebycaleb is this related to your previous work? If yes, I'll let you do the review. Thanks!

Copy link
Contributor

@codebycaleb codebycaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 💯 to me! It should definitely be a safer bet than 90 days.

@armchairlinguist armchairlinguist merged commit 51b7a8c into master Dec 9, 2020
@armchairlinguist armchairlinguist deleted the supportesc-101_30-days branch December 9, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants