Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE-2085 chore: bump node-fetch to 2.6.6 #459

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Dec 1, 2021

Same as #458 but for 11.x.

@eliangcs eliangcs requested a review from xavdid as a code owner December 1, 2021 06:39
@eliangcs eliangcs changed the title chore: bump node-fetch to 2.6.6 PDE-2085 chore: bump node-fetch to 2.6.6 Dec 1, 2021
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. Is there a reason for the bump, or just staying current? Do we anticipate any issues in legacy-script runner on the 9.x branch?

@eliangcs
Copy link
Member Author

eliangcs commented Dec 1, 2021

@xavdid thanks for asking! I wrote the reason in the description of #458.

@xavdid
Copy link
Contributor

xavdid commented Dec 1, 2021

wow those checks were so fast 😅

@eliangcs eliangcs merged commit caa4b2a into master Dec 1, 2021
@eliangcs eliangcs deleted the bump-node-fetch-11.x branch December 1, 2021 06:46
@eliangcs
Copy link
Member Author

eliangcs commented Dec 1, 2021

wow those checks were so fast

Exactly! We should've moved away from Travis earlier. I don't know why, but the latency between GitHub Actions and our test servers (https://httpbin.zapier-tooling.com and https://auth-json-server.zapier-staging.com) is super short!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants