PDE-2946 fix(core): fix value.replace is not a function when resolving missing curlies (9.x backport)

[eliangcs]

Given bundle.inputData.foo is non-existent, doing this will give you value.replace is not a function error:

const perform = (z, bundle) => {
  const response = await z.request({
    url: 'https://example.com',
    method: 'POST',
    body: {
      inputs: ['{{bundle.inputData.foo}}'],
    }
  });
  return z.JSON.parse(response.content);
};

And this is the traceback:

Unhandled error: TypeError: value.replace is not a function
TypeError: value.replace is not a function
    at handleEmpty (:censored:9:d1ba0cf2aa:/node_modules/zapier-platform-core/src/tools/cleaner.js:137:27)
    at :censored:9:d1ba0cf2aa:/node_modules/zapier-platform-core/src/tools/cleaner.js:150:7
    at Array.forEach (<anonymous>)
    at normalizeEmptyRequestFields (:censored:9:d1ba0cf2aa:/node_modules/zapier-platform-core/src/tools/cleaner.js:148:30)
    at coerceBody (:censored:9:d1ba0cf2aa:/node_modules/zapier-platform-core/src/http-middlewares/before/prepare-request.js:63:5)
    at prepareRequest (:censored:9:d1ba0cf2aa:/node_modules/zapier-platform-core/src/http-middlewares/before/prepare-request.js:137:9)
    at Object.<anonymous> (:censored:9:d1ba0cf2aa:/node_modules/zapier-platform-core/src/middleware.js:66:31)

There are two problems with the regex .test() method.

First, .test() method can actually return true even if the input is a non-string. In this case, you can pass in an array and get a true:

> isCurlies = /{{.*?}}/g
/{{.*?}}/g
> isCurlies.test(['{{foo}}'])
true      // <- surprise!

Second, when working with the "global" (/.../g) flag, .test() saves the state between calls:

> isCurlies = /{{.*?}}/g
/{{.*?}}/g
> s = '{{test}}'
> isCurlies.test(s)
true
> isCurlies.test(s)
false    // <- another surprise!

Here is how we fix:

• make sure value is a string before we match it with a regex
• don't use isCurlies.test(value); use value.search(isCurlies) >= 0 instead